[fs.op.funcs] Separate effects from returns. #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix. |
|
Fixed. |
tkoeppe
reviewed
Nov 25, 2017
source/iostreams.tex
Outdated
| \tcode{false}, an error is reported\iref{fs.err.report}. | ||
|
|
||
| \pnum | ||
| \returns An unspecified directory path suitable for temporary files. |
There was a problem hiding this comment.
Hm, I think it would be nice if we could make reference to p in the Returns element. Maybe the "unspecified directory path..." could move up into the defining paragraph, and we could say "returns p" here?
There was a problem hiding this comment.
Sounds like a good idea.
|
Rebased + rephrased for temp_directory_path(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815.