Remove \tilde in favour of \~. #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godbyk
reviewed
Dec 2, 2017
| @@ -199,8 +199,6 @@ | |||
| \newcommand{\bigoh}[1]{\ensuremath{\mathscr{O}(#1)}} | |||
|
|
|||
| % Make all tildes a little larger to avoid visual similarity with hyphens. | |||
| % FIXME: Remove \tilde in favour of \~. | |||
| \renewcommand{\tilde}{\textasciitilde} | |||
| \renewcommand{\~}{\textasciitilde} | |||
There was a problem hiding this comment.
Note that this overrides the default definition of \~ which applies the tilde accent to the following character (e.g., \~n is typeset as ‘ñ’).
In addition, I would move the \raisebox etc. code to this macro and leave the \textasciitilde macro unmolested. (Modify as few original macros as necessary. Try to keep all your changes localized.) This also saves you from having to copy the definition to \OldTextAsciiTilde, removes redirection, and improves readability.
There was a problem hiding this comment.
@godbyk: Could you spell that out for me? I've tried a few things, but they end up visually different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a FIXME in macros.tex.
No visible difference.