Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filesystems] 'dot' and 'dot-dot' are not \grammarterms #1863

Merged
merged 1 commit into from Feb 12, 2018

Conversation

jensmaurer
Copy link
Member

Fixes #1527.

@tkoeppe tkoeppe requested a review from jwakely November 29, 2017 23:19
@@ -10544,7 +10544,7 @@
The \defn{parent directory} of a directory is
the directory that both contains a
directory entry for the given directory and is represented by the filename
\grammarterm{dot-dot} in the given directory.
dot-dot in the given directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a forward reference to the definition or "dot-dot", given that it occurs after this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@jensmaurer
Copy link
Member Author

Rebased + updated as per @jwakely's suggestion.

The filename \grammarterm{dot-dot} is treated as a reference to the parent directory.
What the filename \grammarterm{dot-dot} refers to
relative to \grammarterm{root-directory} is \impldef{meaning of \grammarterm{dot-dot} in \grammarterm{root-directory}}.
The filename dot is treated as a reference to the current directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The filename dot" sounds like a particular kind of dot, not a particular kind of filename. How about changing to "The dot filename" and "the dot-dot filename" throughout?

Copy link
Member Author

@jensmaurer jensmaurer Dec 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out only this place (and one other) need changing; all other places already say "dot filename" or similar.

@jensmaurer
Copy link
Member Author

Rebased + updated.

@zygoloid zygoloid merged commit f39be10 into cplusplus:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants