Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[language.support, utilities] Condense description of exception classes #1867

Merged
merged 1 commit into from Jun 5, 2019

Conversation

jensmaurer
Copy link
Member

Fixes #748.

@jensmaurer
Copy link
Member Author

Note that this currently has a lame sentence "The constructors are specified in \ref{exception}." to point readers to the paragraph that says "all standard library classes T deriving from std::exception have these constructors". I've also removed the NTBS blurb from the derived classes; it's now implied by std::exception::what(). Maybe we can get rid of the lame sentence and just add a comment in the class synopsis, saying something like "// see also \ref{exception}. Suggestions welcome.

Oh, and before I forget: This is borderline editorial; for @zygoloid to decide.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 30, 2017
@zygoloid
Copy link
Member

I would prefer a comment inside the class definition pointing at [exception] rather than wording in a section that a casual reader may well not look at.

Just using the defaulted special members here seems very reasonable to me. I think it's fine that we now give these exception subclasses move operations, but a second opinion on that would be good (@jwakely?).

@jensmaurer
Copy link
Member Author

jensmaurer commented Feb 13, 2018

Updated.

The fun part is that logic_error and other classes from <stdexcept> that take a user-defined string now also have a default constructor per [exception]. That might be undesirable, and is definitely not an editorial change.

@jensmaurer
Copy link
Member Author

Fixed the "logic_error now has a default constructor" issue.

We might want to have LWG ack the changes.

@zygoloid zygoloid added the after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. label Mar 16, 2018
@jensmaurer
Copy link
Member Author

Editorial meeting consensus: Looks like the right direction. @zygoloid asks for LWG expert review. @jwakely ?

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 2, 2018

@jwakely: Ping

@tkoeppe tkoeppe removed the after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. label Apr 3, 2018
@tkoeppe tkoeppe added the lwg Issue must be reviewed by LWG. label Jun 7, 2018
@zygoloid zygoloid force-pushed the master branch 2 times, most recently from e3dbfe2 to 1a21a65 Compare July 7, 2018 23:19
@jensmaurer
Copy link
Member Author

Rebased.

@jensmaurer
Copy link
Member Author

Rebased.

@jwakely, ping?

@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 15, 2019
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label May 28, 2019
@jensmaurer
Copy link
Member Author

@jwakely, ping^2.

@jensmaurer jensmaurer added decision-required A decision of the editorial group (or the Project Editor) is required. and removed decision-required A decision of the editorial group (or the Project Editor) is required. lwg Issue must be reviewed by LWG. labels May 29, 2019
@zygoloid zygoloid merged commit 5b8ed33 into cplusplus:master Jun 5, 2019
@jensmaurer jensmaurer deleted the b2 branch June 5, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions classes deriving directly from std::exception should be presented consistently
4 participants