Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[string.cons] Editorial change for caption on table 56 #1875

Closed
mclow opened this issue Dec 3, 2017 · 4 comments
Closed

[string.cons] Editorial change for caption on table 56 #1875

mclow opened this issue Dec 3, 2017 · 4 comments

Comments

@mclow
Copy link
Contributor

mclow commented Dec 3, 2017

LWG closed issue 3033 as "NAD editorial", with a suggestion that changing the caption on the table would be both editorial and sufficient.

The current caption is "basic_string(const basic_string&) effects"

My first suggestion is: "basic_string(const basic_string&) and basic_string(const basic_string&&) effects", but I'm not going to insist on that.

The discussion occurred on the -lib reflector in the thread titled "Issue 3033: basic_string move ctor is underspecified"
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 3, 2017

Can I make a counter-proposal to just remove the tables outright and replace them with standard Postconditions elements? @zygoloid, would you support that?

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 3, 2017

Proposal:

image

@jensmaurer
Copy link
Member

Those constructor postcondition tables are odd, and telling the reader the state of three data members doesn't seem overly obtuse to warrant separate tables.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 3, 2017

I believe at some point in the past there was one table that was shared between two \itemdescs. However, I merged those two separate items into one a few months ago, and now we have literally one table per item. So I think the time has come for those tables to pass on to a better place.

@jensmaurer jensmaurer changed the title Editorial change for caption on table 56 [string.cons] Editorial change for caption on table 56 Dec 4, 2017
@tkoeppe tkoeppe mentioned this issue Dec 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mclow @tkoeppe @jensmaurer