[over] Replace \term with \defnx to add index entries #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Feb 12, 2018
source/overloading.tex
Outdated
| An | ||
| \term{implicit conversion sequence} | ||
| \indextext{sequence!implicit conversion}% | ||
| An \defnx{implicit conversion sequence}{sequence!implicit conversion} |
There was a problem hiding this comment.
Yuck. Can we index this as "conversion sequence!implicit" rather than "sequence!implicit conversion"? Also, a \see from "implicit conversion sequence" would be really useful.
zygoloid
reviewed
Feb 12, 2018
source/overloading.tex
Outdated
| @@ -2484,18 +2475,18 @@ | |||
| \pnum | |||
| This subclause defines a partial ordering of implicit conversion | |||
| sequences based on the relationships | |||
| \term{better conversion sequence} | |||
| \defnx{better conversion sequence}{conversion!sequence!better} | |||
There was a problem hiding this comment.
I think we should keep "conversion sequence" separate from "conversion" in the index, since they have quite different sets of rules.
|
Addressed @zygoloid's review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #329.