[expr.typeid, time.syn, class.access.base] Replace \term with \placeholder where appropriate. #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older where appropriate.
jensmaurer
reviewed
Feb 13, 2018
| @@ -2770,7 +2770,7 @@ | |||
| \indextext{\idxcode{type_info}}% | |||
| \indexlibrary{\idxcode{type_info}}% | |||
| \tcode{const} \tcode{std::type_info}\iref{type.info} and dynamic type \tcode{const} | |||
| \tcode{std::type_info} or \tcode{const} \term{name} where \term{name} is an | |||
| \tcode{std::type_info} or \tcode{const} \placeholder{name} where \placeholder{name} is an | |||
There was a problem hiding this comment.
In general, I think we should use "\placeholder" for math-style single-letter variables, so these should probably be switched to "N" or "C". (The latter preferred; "N" is a namespace.)
jensmaurer
reviewed
Feb 13, 2018
| using milliseconds = duration<@\placeholder{signed integer type of at least 45 bits}@, milli>; | ||
| using seconds = duration<@\placeholder{signed integer type of at least 35 bits}@>; | ||
| using minutes = duration<@\placeholder{signed integer type of at least 29 bits}@, ratio< 60>>; | ||
| using hours = duration<@\placeholder{signed integer type of at least 23 bits}@, ratio<3600>>; |
There was a problem hiding this comment.
Sigh. Yeah, until we find better phrasing.
tkoeppe
added
the
needs rebase
|
@Eelis: ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No visible difference.