Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utility] Make content in hanging paragraph non-normative. #1920

Closed
wants to merge 1 commit into from

Conversation

jensmaurer
Copy link
Member

Partially addresses #1771.

\pnum
The header \tcode{<utility>} defines several types and function templates
that are described in this Clause. It also defines the template \tcode{pair}
and various function templates that operate on \tcode{pair} objects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What on earth is the special call-out to pair achieving here? The header also defines in_place_index and index_sequence_for. Maybe this sentence came from an older time when pair really was the only class template here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pre-existing text that just got moved (from below the synopsis). There are similar introductory notes for most of the header synopses. If you feel this particular intro text warrants improvement, feel free to suggest something in a separate pull request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me just keep this open so as to not forget.

@zygoloid, @jwakely: do you think we should list all the other class templates explicitly in this strange little sentence, or do something more radical (such as removing it altogether)?

Copy link
Member

@zygoloid zygoloid Apr 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we just drop this entirely. If someone wants to know what's in <utility>, that's what the synopsis is for. I don't see any point in including a paragraph that says "The header <utility> includes the stuff we say it includes in the synopsis."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could ditch this and move the hanging paragraph into this section, replacing "This subclause" with "The header <utility>".

@jensmaurer
Copy link
Member Author

Rebased.

@zygoloid
Copy link
Member

zygoloid commented Apr 2, 2018

Merged with @tkoeppe's suggestion and committed as 63dd5c6.

@zygoloid zygoloid closed this Apr 2, 2018
@jensmaurer jensmaurer deleted the b9 branch April 3, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants