Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rand.req.eng] Use \text, not \mbox, in math mode #1921

Merged
merged 1 commit into from Feb 14, 2018
Merged

[rand.req.eng] Use \text, not \mbox, in math mode #1921

merged 1 commit into from Feb 14, 2018

Conversation

jensmaurer
Copy link
Member

Fixes #1344.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 14, 2018

Does this produce a visual difference?

@jensmaurer
Copy link
Member Author

No.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 14, 2018

OK, thanks. For the future, beware that \text respects the ambient italicization state (e.g. from \emph), so there are situations were you'd prefer \mathrm over \text. But it's fine here.

@tkoeppe tkoeppe merged commit 9e4bba5 into cplusplus:master Feb 14, 2018
@jensmaurer jensmaurer deleted the b10 branch February 14, 2018 21:04
@Eelis
Copy link
Contributor

Eelis commented Feb 14, 2018

Aww, this would've been a perfect opportunity to also fix #1340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jensmaurer @tkoeppe @Eelis