Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unord] "Specialized algorithms" vs. "Swap" #1935

Closed
jensmaurer opened this issue Feb 19, 2018 · 1 comment
Closed

[unord] "Specialized algorithms" vs. "Swap" #1935

jensmaurer opened this issue Feb 19, 2018 · 1 comment
Assignees
@jensmaurer

Comments

@jensmaurer
Copy link
Member

The original containers use the heading "Specialized algorithms" for the section whose only purpose is to overload std::swap(). The unordered containers (which are fairly new) use the heading "Swap". That's inconsistent.

My personal view is that we should remove that subclause entirely:

  • The declaration is already shown in the header synopsis.
  • The meaning should be established by some front-matter wording in the container requirements, which we already have. Maybe add "equivalent to:" in front of the a.swap(b) equivalence in the corresponding table row so that noexcept is the same.
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Feb 19, 2018
@jensmaurer
Copy link
Member Author

Editorial meeting consensus: Add "equivalent to" in front of the a.swap(b) equivalence in the container requirement table. Remove all sections describing "swap" from the specific container subclauses. Leave array, queue, priority_queue, stack alone. Deleting stable labels needs announcement to Marshall and Daniel Krügler.

@zygoloid zygoloid removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Mar 16, 2018
@jensmaurer jensmaurer mentioned this issue Mar 23, 2018
Merged
@jensmaurer jensmaurer self-assigned this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zygoloid @jensmaurer