Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fs.class.filesystem_error] Rephrase para 1 to avoid "class defines t… #1943

Closed

Conversation

CaseyCarter
Copy link
Contributor

…ype"

@jensmaurer
Copy link
Member

I support this change; it's a net improvement. But [res.on.exception.handling] already discusses derived classes; it would be good to defer the exact set of types that could be thrown to that section. Also, [except.handle] explains that only unambiguous public base classes fit, so something like
class D : private filesystem_error { };
is not suitable (but fits the wording as proposed).

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 30, 2018

@jensmaurer: Do you want a more extensive change here, or is it OK as is?

@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 30, 2018
@jensmaurer
Copy link
Member

@tkoeppe: The proposed wording is not ok; it incorrectly handles private and ambiguous base classes.

@CaseyCarter
Copy link
Contributor Author

The proposed wording is not ok

+1, this is broken and I need to fix it. Actually, I'll just close the PR until I have new wording.

@CaseyCarter CaseyCarter deleted the filesystem_error_cleanup branch December 16, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants