Use \placeholder for alias templates in container deduction guides #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's very nice! |
timsong-cpp
reviewed
Mar 24, 2018
source/containers.tex
Outdated
| \begin{codeblock} | ||
| template<class InputIterator> | ||
| using @\placeholder{iter-value-type}@ = | ||
| typename iterator_traits<InputIterator>::value_type>; // \expos |
timsong-cpp
reviewed
Mar 24, 2018
source/containers.tex
Outdated
| @@ -5797,13 +5797,16 @@ | |||
|
|
|||
| \begin{codeblock} | |||
| template<class InputIterator> | |||
| using iter_key_t = remove_const_t< | |||
| using @\placeholder{iter-value-type}@ = | |||
| typename iterator_traits<InputIterator>::value_type>; // \expos | |||
There was a problem hiding this comment.
fixed both of these, thanks.
…plates Also rename iter_val_t to iter-mapped-type and then add iter-value-type for value_type. Fixes cplusplus#1523
|
I've stolen your commits and altered them. (I adjusted the horizontal spacing, removing extraneous line breaks, harmonizing the comment column, etc.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the alias templates and style as placeholders:
iter_key_t-> iter-key-typeiter_val_t-> iter-mapped-typeiter_to_alloc_t-> iter-to-alloc-typeAdd iter-value-type for use in sequence containers and sets.
Fixes #1523