Update container advice #1989
Merged
Update container advice #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still somewhat out of date, but better.
|
This whole paragraph has no normative impact and should be removed outright or at best turned into a note. |
|
Or remove the rest and just leave my Seuss-ism. :-) |
|
Seuss note sounds good IMO. |
|
Please add "[sequence.reqmts]" (the label for the subclause that is changed) to the start of your commit message. Please turn p2 into a note instead of adding semi-funny normative statements. |
jensmaurer
added
the
needs rebase
|
Sorry to be a pest, but if we remove the rest, then what is best? This thread is vest(ed) and gone west. |
Also separate out the advice for std::array from that for std::vector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still somewhat out of date, but better.