Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P0969R0 editorial fix #1998

Closed
wants to merge 1 commit into from
Closed

P0969R0 editorial fix #1998

wants to merge 1 commit into from

Conversation

zygoloid
Copy link
Member

Proposed editorial improvement to [dcl.struct.bind]p4:

  • removes unusual grammar construction "[...], well-formed [...]"
  • defines the name placeholder used in the e.name expressions

@zygoloid zygoloid added the cwg Issue must be reviewed by CWG. label Mar 28, 2018
@zygoloid zygoloid changed the base branch from master to motions-2018-03-cwg-4 March 29, 2018 01:10
@zygoloid zygoloid changed the base branch from motions-2018-03-cwg-4 to master March 29, 2018 01:10
@zygoloid zygoloid force-pushed the master branch 2 times, most recently from e3dbfe2 to 1a21a65 Compare July 7, 2018 23:19
@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Sep 7, 2018
@zygoloid zygoloid removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 9, 2018
@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 9, 2018
@tkoeppe
[dcl.struct.bind] Reworded "well-formed when named as e./name/"
46fe4f4 
to form a complete sentence and clarify what e./name/ refers to.
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 11, 2018
@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 7, 2018
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 25, 2020

Is this obsolete now, @zygoloid?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 19, 2021

The current wording now seems very close to what's proposed here; closing.

@tkoeppe tkoeppe closed this Jun 19, 2021
@jensmaurer jensmaurer deleted the p0969r0-editorial-fix branch July 23, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cwg Issue must be reviewed by CWG. needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zygoloid @tkoeppe @jensmaurer