Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[time.cal.month.nonmembers,time.cal.wd.nonmembers] Do not digress to … #1999

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jensmaurer
Copy link
Member

…Eucledian algorithm.

Fixes #1974.

@jensmaurer
Copy link
Member Author

This puts additional burden on the implementation, because it has to avoid overflow in all cases, likely requiring additional run-time branches in cases where sizeof(long long) == sizeof(int). Can we do this without LWG input?

@zygoloid zygoloid added the lwg Issue must be reviewed by LWG. label Mar 29, 2018
@zygoloid
Copy link
Member

zygoloid commented Mar 29, 2018

This is a normative change in the overflow case; let's ask LWG to take a look and open an issue based on this wording change if they agree a change is warranted.

@jensmaurer
Copy link
Member Author

Rebased.

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 26, 2018
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lwg Issue must be reviewed by LWG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[time.cal] improve std::chrono::month operator+'s description of arithmetic mod 12
3 participants