New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[numarray] Wildly inconsistent formatting for valarray helpers #2023
Comments
Some of those paragraphs were also incorrectly indented, but I've fixed that in c9e60ab |
It should be |
Thanks! |
So, we're actually repairing valarray wording? Shocking. |
Does anybody except me care about the other inconsistencies? The "It has reference semantics ..." wording is part of p1 in [template.slice.array.overview] but is a separate paragraph p2 in the other three places. The explanation of the effects ("the expression ... has the effect of ...") is an Example: in [template.slice.array.overview], its own paragraph in [template.gslice.array.overview], and part of p2 in [template.mask.array.overview] and [template.indirect.array.overview]. |
I can send a pull request if we agree which presentation to use. |
@jwakely: "The "It has reference semantics ..." wording is part of p1 in [template.slice.array.overview] but is a separate paragraph p2 in the other three places." This has been addressed in the patch; it's p2 as well, now. "The explanation of the effects ("the expression ... has the effect of ...") is an Example: in [template.slice.array.overview]," Addressing this would mean adding normative wording to an underspecified facility -> LWG issue, I'd say. I agree with merging p3 in [template.gslice.array.overview] with its preceding paragraph for consistency. |
There are a number of apparently unnecessary inconsistencies between [template.slice.array.overview], [template.gslice.array.overview], [template.mask.array.overview], and [template.indirect.array.overview].
[template.slice.array.overview] p1 says:
And [template.gslice.array.overview] p1 says:
Either the latter should say "
gslice
subscript operator" or the wordslice
should not be in code font (which would be consistent with "mask subscript operator" and "indirect subscript operator" in [template.mask.array.overview] and [template.indirect.array.overview] respectively).Also [template.slice.array.overview] p1 says "The
slice_array
template is a helper template" but the other three helpers say "This template is a helper template". Presumably they could be consistent.The "It has reference semantics ..." wording is part of p1 in [template.slice.array.overview] but is a separate paragraph p2 in the other three places.
The explanation of the effects ("the expression ... has the effect of ...") is an Example: in [template.slice.array.overview], its own paragraph in [template.gslice.array.overview], and part of p2 in [template.mask.array.overview] and [template.indirect.array.overview].
The text was updated successfully, but these errors were encountered: