Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use \commentellip macro for omitted program text. #2027

Merged
merged 1 commit into from Apr 14, 2018

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Apr 13, 2018

Fixes #1390.

@@ -606,13 +606,13 @@
The enumerated type \tcode{\placeholder{enumerated}} can be written:

\begin{codeblock}
enum @\placeholder{enumerated}@ { @$\tcode{\placeholder{V}}_{0}$@, @$\tcode{\placeholder{V}}_{1}$@, @$\tcode{\placeholder{V}}_{2}$@, @$\tcode{\placeholder{V}}_{3}$@, ..... };
enum @\placeholder{enumerated}@ { @$\tcode{\placeholder{V}}_{0}$@, @$\tcode{\placeholder{V}}_{1}$@, @$\tcode{\placeholder{V}}_{2}$@, @$\tcode{\placeholder{V}}_{3}$@, @$\cdots$@ };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these "center dots"? Why not dots on the baseline (\ldots)? Center dots are for omitted operands of binary folds, like "1 + 2 + \cdots + n".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because @zygoloid wanted "center dots"; see #1390 item 3 "The ..... mega-ellipses should be excised. These should be center dots for horizontal lists and vertical dots for vertical lists."
I'd be happy to do \ldots (they do seem to look better in this context), but we'd need a change of opinion from the Project Editor for that.
Would it speed up the merge if I split this patch from the \commentellip additions? Those seem uncontroversial.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like (it will have been) an oversight that we should fix. Sure, omit this file from the change and I'll commit the rest.

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 13, 2018

I take it all the \commentellip uses are in non-normative code?

@jensmaurer
Copy link
Member Author

I've double-checked the added ones, and they're all in notes and/or examples. (We can discuss separately whether we want to change \commentellip to use \ldots or other non-\tcode dots.)

@jensmaurer
Copy link
Member Author

@tkoeppe: Reduced pull request to just the \commentellip changes; the remainder is covered by #2031.

@tkoeppe tkoeppe merged commit 32eae82 into cplusplus:master Apr 14, 2018
@jensmaurer jensmaurer deleted the b6 branch April 14, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants