[time.syn][time.zone] Various editorial fixes #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! I've asked Howard to take a look. |
zygoloid
reviewed
Apr 14, 2018
| @@ -27272,7 +27272,7 @@ | |||
| \remarks | |||
| This constructor does not participate in overload resolution unless | |||
| \begin{codeblock} | |||
| declval<TimeZonePtr&>()->to_sys(local_time<Duration>{}) | |||
| decltype(declval<TimeZonePtr&>()->to_sys(local_time<Duration>{})) | |||
There was a problem hiding this comment.
Do we really need / want a decltype here? "is (implicitly) convertible to" is defined for an expression and a destination type, not for a source type and a destination type (this actually matters in some cases, such as when the source expression is a bit-field and the destination is a reference type -- but probably not in this case).
I've opened #2029 for the general problem with the library using the meaningless term "is convertible to".
There was a problem hiding this comment.
I mostly wanted local consistency and to avoid suggesting that the expression is actually evaluated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator!=forzoned_time. [operators] does not apply because this comparison is heterogeneous (can have differentDurationtypes).TimeZonePtr2-related typos inzoned_time.