New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[class.spaceship] Use math mode for the entire formula, #2034
Conversation
If no such index exists, \tcode{V} is | ||
\tcode{std::strong_ordering::equal} converted to \tcode{R}. | ||
|
||
\pnum | ||
The \defn{common comparison type} \tcode{U} | ||
of a possibly-empty list of $n$ types | ||
\tcode{T}$_0$, \tcode{T}$_1$, $\cdots$, \tcode{T}$_{n-1}$ | ||
$\tcode{T}_0$, $\tcode{T}_1$, $\dotsc$, $\tcode{T}_{n-1}$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer a non-math \ldots here, since we don't have math commas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're doing this style elsewhere, too: "grep dotsc *.tex"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that's unfortunate, but fine.
source/special.tex
Outdated
where \tcode{x}$_i$ \tcode{<=>} \tcode{y}$_i$ | ||
yields a result value \tcode{v}$_i$ where \tcode{v}$_i$\tcode{ != 0}, | ||
where $\tcode{x}_i$ \tcode{<=>} $\tcode{y}_i$ | ||
yields a result value $\tcode{v}_i$ where $\tcode{v}_i \tcode{!= } 0$, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it you've checked that the spacing after != looks right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eek. Add a \,
-space before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or see how it looks without the space in the tcode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose using \mathrel
: $\tcode{v}_i$ where $\tcode{v}_i \mathrel{\tcode{!=}} 0$
. \mathrel
provides the same spacing around its contents as TeX provides around other math relations (e.g., =, >).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, \mathrel is the right thing. (I've used that before for similar situations.) Thanks, Kevin!
not just for the subscript. Also use \dotsc, not center dots, for comma-separated lists.
not just for the subscript.
Also use \dotsc, not center dots, for comma-separated lists.