Order library comparisons canonically #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order [==, !=, <, >, <=, >=] seems to be most common. Let's make it canonical and use it uniformly.
CaseyCarter
referenced
this pull request
in tzlaine/draft
Apr 26, 2018
zygoloid
reviewed
May 7, 2018
| @@ -14939,7 +14939,7 @@ | |||
|
|
|||
| \pnum | |||
| \begin{note} The current path as returned by many operating systems is a dangerous | |||
| global variable. It may be changed unexpectedly by a third-party or system | |||
| global variable. It may be changed unexpectedly by third-party or system | |||
There was a problem hiding this comment.
For future reference, I'd generally prefer for unrelated fixes such as this and the "duration" -> "duration's" change below to be provided as a separate pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order [
==,!=,<,>,<=,>=] seems to be most common. Let's make it canonical and use it uniformly.