[atomics.types.operations] Avoid inappropriate use of 'underlying type' #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was worried by #2057 that some in SG1 may have Opinions on this wording, despite it being in a note, but this suggested update seems totally fine and I don't think SG1 would care. LGTM! |
tkoeppe
added
the
needs rebase
jensmaurer
removed
the
needs rebase
|
Rebased. |
jwakely
approved these changes
Jun 27, 2018
|
Given the recent changes to compare-and-swap semantics, would it now be more useful to say "value representation" instead of "object representation"? (The memcpy / memcmp semantics only apply when the value representation and object representation are the same, but it may be more obvious if we reinforce that here.) |
|
@zygoloid, agreed. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2057.