Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[output.iterators] Strike useless sentence from note #2083

Merged
merged 1 commit into from Jun 27, 2018

Conversation

CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented May 24, 2018

There's no such thing as an "insert iteratorpointer," and the rest of this sentence isn't much better. Let's just strike it.

@timsong-cpp
Copy link
Contributor

insert_iterator is a thing. "insert pointer", OTOH, not so much.

@jwakely
Copy link
Member

jwakely commented May 30, 2018

I think "the standard is not a tutorial" justifies striking this.

@CaseyCarter
Copy link
Contributor Author

I think "the standard is not a tutorial" justifies striking this.

I think @timsong-cpp's comment is rightfully poking fun at me saying "insert iterator" when I meant to say "insert pointer". And yes, the motivation for striking the remainder of the sentence is that it's incomplete, and so ridiculously tutorial as to not be worth fixing.

There's no such thing as an "insert pointer," and the rest of this sentence isn't much better. Let's just strike it.
@jensmaurer
Copy link
Member

I'm ok with this change.

@tkoeppe tkoeppe added the after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. label Jun 8, 2018
@tkoeppe tkoeppe requested a review from jwakely June 27, 2018 10:45
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 27, 2018

"Insert pointer to joke here."

@tkoeppe tkoeppe merged commit 33e8e2b into cplusplus:master Jun 27, 2018
@CaseyCarter CaseyCarter deleted the patch-4 branch June 27, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants