[span.overview] fix reverse_iterator for span #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a common convention to omit 'std::' when not strictly needed, other than for 'std::move' and 'std::forward'. A third case is for 'reverse_iterator' and 'const_reverse_iterator' type aliases inside a class definition, as the leading 'reverse_iterator' type alias hides the 'std' version from the 'const_reverse_iterator' definition, and subsequently fails to compile. This patch restore the class definition to a safely copy/pastable state. An additional review indicated this convention has been applied correctly for every othert potential occurrence in the library.
tkoeppe
added
the
after-motions
jwakely
approved these changes
Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a common convention to omit 'std::' when not strictly needed,
other than for 'std::move' and 'std::forward'. A third case is for
'reverse_iterator' and 'const_reverse_iterator' type aliases inside a
class definition, as the leading 'reverse_iterator' type alias hides
the 'std' version from the 'const_reverse_iterator' definition, and
subsequently fails to compile. This patch restore the class definition
to a safely copy/pastable state.
An additional review indicated this convention has been applied correctly
for every othert potential occurrence in the library.