Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018-06 LWG Motion 24] P0019R8 Atomic ref #2141

Closed
jensmaurer opened this issue Jun 9, 2018 · 7 comments
Closed

[2018-06 LWG Motion 24] P0019R8 Atomic ref #2141

jensmaurer opened this issue Jun 9, 2018 · 7 comments
Assignees
Milestone

Comments

@jensmaurer
Copy link
Member

jensmaurer commented Jun 9, 2018

No description provided.

@jensmaurer jensmaurer added this to the post-2018-06 milestone Jun 9, 2018
@jensmaurer jensmaurer changed the title [2018-06 LWG Motion 24] P0019R8 Atomic Ref [2018-06 LWG Motion 24] P0019R8 Atomic ref Jun 9, 2018
@jensmaurer
Copy link
Member Author

"The __cpp_lib_atomic_ref feature test macro should be added."

@jfbastien
Copy link
Contributor

jfbastien commented Jun 11, 2018

Did we ever resolve if D1123r0 could be applied editorially, or whether it'll require extra approval in San Diego? It might be useful to go through CWG, and maybe wait for #2105 resolution.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 11, 2018

Since D1123 is not editorial, but normative, I would very much like such a document to be reviewed by CWG.

@AlisdairM
Copy link
Contributor

Consensus was that D1123r0 went beyond editorial guidance, so needs a separate review (and likely updates) for San Diego.

@zygoloid zygoloid self-assigned this Jun 11, 2018
@jensmaurer jensmaurer assigned jensmaurer and unassigned zygoloid Jun 12, 2018
@jensmaurer
Copy link
Member Author

jensmaurer commented Jun 12, 2018

This paper claims "For signed integer types, arithmetic is defined to use two’s complement representation. There are no undefined results." but atomic_ref operates on an existing object of type T. What if that type T has sign-magnitude representation and the operation happens to produce INT_MIN in two's complement, which is not representable as a sign-magnitude number?

@jensmaurer
Copy link
Member Author

"The __cpp_lib_atomic_ref feature test macro should be added."

@jfbastien
Copy link
Contributor

This paper claims "For signed integer types, arithmetic is defined to use two’s complement representation. There are no undefined results." but atomic_ref operates on an existing object of type T. What if that type T has sign-magnitude representation and the operation happens to produce INT_MIN in two's complement, which is not representable as a sign-magnitude number?

p0907 was forwarded to CWG and should get into the draft soon. Maybe open an issue and we can close as NAD if p0907 makes it through?

zygoloid added a commit that referenced this issue Jun 22, 2018
zygoloid added a commit that referenced this issue Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants