Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0929R2 Checking for abstract class types #2149

Merged
merged 3 commits into from Jun 18, 2018
Merged

Conversation

jensmaurer
Copy link
Member

Added cross-reference from the new use of 'abstract class
type' in [except.throw], pointing to [class.abstract].

Fixes #2117.

@jensmaurer jensmaurer added this to the post-2018-06 milestone Jun 10, 2018
@zygoloid
Copy link
Member

It looks like [temp.deduct]p11 bullet 2 also needs an update. Eg:

template<typename T> void f(T (*)[5]);
struct Abstract { virtual ~Abstract() = 0; };
void g() { f<Abstract>(nullptr); } // now ok, despite what bullet 2 says

Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application of motion looks fine, but I'd like an additional fix to the note in [temp.deduct]p11, specifically in bullet 2.

@zygoloid
Copy link
Member

Also, from the wording paper: "Editorial note: I suggest to move the statement about function definitions to 11.4 [dcl.fct.def]." This seems like a good idea to me; please either do this or open an issue so we don't forget.

@jensmaurer
Copy link
Member Author

I've fixed the two issues you mentioned, @zygoloid.

Added cross-reference from the new use of 'abstract class
type' in [except.throw], pointing to [class.abstract].
This is the rule that requires complete non-abstract
types function parameter or return types.
@zygoloid zygoloid merged commit f5ebcca into master Jun 18, 2018
@jensmaurer jensmaurer deleted the motions-2018-06-cwg-5 branch October 19, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants