New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P0892R2 explicit(bool) #2152
P0892R2 explicit(bool) #2152
Conversation
source/special.tex
Outdated
@@ -103,7 +103,7 @@ | |||
The \grammarterm{class-name} shall not be a \grammarterm{typedef-name}. In a constructor | |||
declaration, each \grammarterm{decl-specifier} in the optional | |||
\grammarterm{decl-specifier-seq} shall be \tcode{friend}, \tcode{inline}, | |||
\tcode{explicit}, or \tcode{constexpr}. | |||
or \tcode{constexpr} or an \grammarterm{explicit-specifier}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrasing here is a bit weird, this parses as "shall be (friend), (inline), or (constexpr or an explicit-specifier)". How about:
shall be
friend
,inline
,constexpr
, or an explicit-specifier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
source/compatibility.tex
Outdated
@@ -1892,6 +1892,26 @@ | |||
}; | |||
\end{codeblock} | |||
|
|||
\rSec2[diff.cpp17.decl]{\ref{dcl.decl}: Declarators} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declarators -> declarators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Change to [dcl.init.aggr] ignored, as the relevant wording was deleted by P1008R1 (applied by 2018-06 CWG Motion 12).
Parenthesized names for explicit constructors and conversion functions are still valid if the name doesn't immediately follow the explicit keyword. Add an example using explicit(true) as a hint indicating how to get the same effect. Change affected subclauses from [dcl.fct] to the somewhat-more-precise [class.ctor] and [class.conv.fct].
300df1b
to
3b24b2d
Compare
Fixes #2128.