Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0646R1 Improving the return value of erase-like algorithms #2165

Merged
merged 1 commit into from Jun 22, 2018

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Jun 11, 2018

Fixes #2143

@jensmaurer jensmaurer added this to the post-2018-06 milestone Jun 12, 2018
@jensmaurer jensmaurer self-requested a review June 15, 2018 09:16
@jensmaurer
Copy link
Member

Feature test macro: __cpp_lib_list_remove_return_type

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the Annex C changes for [diff.cpp17.containers].

@jwakely
Copy link
Member Author

jwakely commented Jun 15, 2018

Looks like I used D0646R1 instead of the one from the straw polls page (which was dumb, as I wrote the Annex C wording so should have noticed it was missing). I'll push a commit to the branch ...

@jwakely
Copy link
Member Author

jwakely commented Jun 15, 2018

Done.

@jensmaurer
Copy link
Member

Uh, @jwakely: The commits should use sentence case, not title case, even if the paper title erred in that regard. Not sure how to fix that without a force-push, though.

@jensmaurer jensmaurer changed the title P0646R1 Improving the Return Value of Erase-Like Algorithms P0646R1 Improving the return value of erase-like algorithms Jun 15, 2018
@jwakely
Copy link
Member Author

jwakely commented Jun 15, 2018

I forgot that rule and did a copy&paste from the paper title, sorry.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 15, 2018 via email

@jensmaurer
Copy link
Member

@tkoeppe Right, but will @zygoloid remember this particular case?

@zygoloid
Copy link
Member

Yes, @zygoloid reads these threads while rebasing and merging :)

@zygoloid
Copy link
Member

Minor adjustments made while merging: changed restrictive "which" to "that" in Annex C, replaced \_ with _ (we use the textunderscore package), replaced "C++" with "\Cpp{}" macro in Annex C.

@zygoloid zygoloid merged commit ad1ad15 into master Jun 22, 2018
@jwakely jwakely deleted the motions-2018-06-lwg-26 branch July 6, 2018 23:30
@jwakely jwakely restored the motions-2018-06-lwg-26 branch July 6, 2018 23:31
@jensmaurer jensmaurer deleted the motions-2018-06-lwg-26 branch October 19, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants