New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P0646R1 Improving the return value of erase-like algorithms #2165
Conversation
Feature test macro: __cpp_lib_list_remove_return_type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the Annex C changes for [diff.cpp17.containers].
Looks like I used D0646R1 instead of the one from the straw polls page (which was dumb, as I wrote the Annex C wording so should have noticed it was missing). I'll push a commit to the branch ... |
Done. |
Uh, @jwakely: The commits should use sentence case, not title case, even if the paper title erred in that regard. Not sure how to fix that without a force-push, though. |
I forgot that rule and did a copy&paste from the paper title, sorry. |
This isn't the end of the world. The application to master is a rebase
anyway at which point we can rename anything we like.
…On Fri, 15 Jun 2018, 14:09 Jonathan Wakely, ***@***.***> wrote:
I forgot that rule and did a copy&paste from the paper title, sorry.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2165 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGFS-YIVm5MdG5jq5tGCG3hYzPohVQ6_ks5t87IigaJpZM4UjhRt>
.
|
88a77c3
to
d5c2f25
Compare
Yes, @zygoloid reads these threads while rebasing and merging :) |
d5c2f25
to
02a2d41
Compare
Minor adjustments made while merging: changed restrictive "which" to "that" in Annex C, replaced |
02a2d41
to
690c0e0
Compare
Fixes #2143