Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0476R2 Bit-casting object representations #2168

Merged
merged 1 commit into from Jun 21, 2018
Merged

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Jun 11, 2018

Editorial changes:

  • Added an entry into Table tab:numerics.lib.summary.
  • Renamed heading "bit manipulation library" to just "bit manipulation".
  • Reordered itemdescr elements to the canonical order.

Fixes #2131.

TODO: add feature test macros once CWG-15 has been merged.

@jensmaurer jensmaurer added this to the post-2018-06 milestone Jun 12, 2018
@jensmaurer jensmaurer self-requested a review June 19, 2018 08:54
@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jun 19, 2018
@jensmaurer
Copy link
Member

jensmaurer commented Jun 19, 2018

CWG Motion 15 (feature-test macros) has landed; please add the macro and rebase.
Otherwise looks good to me.

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described above, please add feature-test macro and rebase.

@jensmaurer
Copy link
Member

Uh, turns out feature-testing has not landed just yet... So I'll call this "approved".

@tkoeppe tkoeppe removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jun 19, 2018
Editorial changes:
* Added an entry into Table tab:numerics.lib.summary.
* Renamed heading "bit manipulation library" to just "bit manipulation".
* Reordered itemdescr elements to the canonical order.
Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added libindex entry for bit_cast, looks good now.

@zygoloid zygoloid merged commit 992feb2 into master Jun 21, 2018
@jensmaurer jensmaurer deleted the motions-2018-06-lwg-13 branch October 19, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants