Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P0019R8 Atomic ref #2172

Merged
merged 1 commit into from Jun 22, 2018
Merged

P0019R8 Atomic ref #2172

merged 1 commit into from Jun 22, 2018

Conversation

jensmaurer
Copy link
Member

Fixes #2141.

@jensmaurer jensmaurer added this to the post-2018-06 milestone Jun 12, 2018
timsong-cpp
timsong-cpp reviewed Jun 18, 2018
View reviewed changes
source/atomics.tex Outdated
\indexlibrarymember{exchange}{atomic_ref<\placeholder{integral}>}%
\indexlibrarymember{exchange}{atomic_ref<\placeholder{floating-point}>}%
\begin{itemdecl}
T exchange(T desired, memory_order order = memory_order_seq_cst) noexcept;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paper is missing a const here, presumably a typo (since it's in the class definition).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

timsong-cpp
timsong-cpp reviewed Jun 18, 2018
View reviewed changes
source/atomics.tex Outdated
\indexlibrarymember{is_always_lock_free}{atomic_ref<\placeholder{integral}>}%
\indexlibrarymember{is_always_lock_free}{atomic_ref<\placeholder{floating-point}>}%
\begin{itemdecl}
static constexpr bool is_always_lockfree;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misspelled in the paper.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah should be is_always_lock_free

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jensmaurer @zygoloid
P0019R8 Atomic ref
8dc9432 
Shortened label for [atomics.ref.memberops]

[atomic.refs.operations] const-qualify 'atomic_ref<T>::exchange'

The synopsis shows the 'const', and applying it is consistent
with the pointer semantics of std::atomic_ref.

[atomics.ref.operations] Fix mis-spelled is_always_lock_free
@zygoloid zygoloid merged commit 7975b29 into master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfbastien jfbastien jfbastien left review comments

@timsong-cpp timsong-cpp timsong-cpp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2018-06
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jensmaurer @jfbastien @timsong-cpp @zygoloid