P1113R0 CWG "ready" Issues for the June, 2018 (Rapperswil) meeting #2186
+73
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
requested changes
Jun 15, 2018
source/templates.tex
Outdated
| }; | ||
| using T1 = X<S, int, int>; // error: too many arguments | ||
| using T2 = X<>; // error: no default argument for first template parameter | ||
| using T3 = X<1>; // error: value 1 does not match type-parameter |
source/templates.tex
Outdated
| template parameter, and is not convertible to the type of the | ||
| corresponding non-type parameter as specified in~\ref{temp.arg.nontype}, | ||
| When an explicit template argument list is specified, if the | ||
| given \grammarterm{template-id} is invalid\iref{temp.names}, |
There was a problem hiding this comment.
invalid -> not valid, to fix the use of an undefined term.
source/templates.tex
Outdated
| type deduction fails. | ||
|
|
||
| \item The specified template argument values are substituted for the | ||
| The specified template argument values are substituted for the |
There was a problem hiding this comment.
Add an "Otherwise" to the start of this sentence for clarity and flow.
There was a problem hiding this comment.
... and pushed as editorial commit.
* Use "not valid" rather than "invalid", since only "valid" has been defined. * Add an "otherwise" to improve flow.
zygoloid
force-pushed
the
motions-2018-06-cwg-1
branch
from
bb52b25 to
5274b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #2113.
Note the comment in that issue.