Harmonize phrasings of "this destructor is trivial" #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Jun 23, 2018
source/utilities.tex
Outdated
| be the $i^\text{th}$ type in \tcode{Types}, and | ||
| $\tcode{U}_i$ be the $i^\text{th}$ type in a template parameter pack named \tcode{UTypes}, where indexing | ||
| is zero-based. | ||
| If \tcode{is_trivially_destructible_v<$\tcode{T}_i$>} is \tcode{true} for all $\tcode{T}_i$ |
There was a problem hiding this comment.
Done! I had initially assumed that [variant.dtor] had omitted the comma to avoid any visual collision with the subscript i, and so I'd followed the rule "comma if-and-only-if no subscript." I've now changed to "always comma," which I agree is more grammatically correct.
jensmaurer
reviewed
Jun 23, 2018
source/utilities.tex
Outdated
| @@ -4148,8 +4148,8 @@ | |||
|
|
|||
| \pnum | |||
| \remarks | |||
| If \tcode{is_trivially_destructible_v<$\tcode{T}_i$> == true} for all $\tcode{T}_i$ | |||
| then this destructor shall be a trivial destructor. | |||
| If \tcode{is_trivially_destructible_v<$\tcode{T}_i$>} is \tcode{true} for all $\tcode{T}_i$ | |||
jensmaurer
requested changes
Jun 23, 2018
|
Thanks. Please squash and force-push (so that there is only one commit pending). |
Inspired by P0602 https://lichray.github.io/trivially_variant.html Zhihao suggested I open an editorial issue if I want to harmonize "trivially destructible" wording across the rest of the Standard, so, here's that editorial issue. I may have gotten carried away while harmonizing http://eel.is/c++draft/tuple.cnstr#4 with http://eel.is/c++draft/variant.ctor#1 but I think it's still "editorial."
jwakely
approved these changes
Jun 24, 2018
jensmaurer
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by P0602 https://lichray.github.io/trivially_variant.html
Zhihao suggested I open an editorial issue if I want to harmonize
"trivially destructible" wording across the rest of the Standard,
so, here's that editorial issue.
I may have gotten carried away while harmonizing
http://eel.is/c++draft/tuple.cnstr#4
with
http://eel.is/c++draft/variant.ctor#1
but I think it's still "editorial."