Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1082R0 LWG Issues to be moved in Rapperswil (except issue 3071) #2193

Merged
merged 14 commits into from Jun 21, 2018

Conversation

jensmaurer
Copy link
Member

Fixes #2129.

@jensmaurer jensmaurer added this to the post-2018-06 milestone Jun 16, 2018
@tkoeppe tkoeppe self-requested a review June 18, 2018 19:44
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 18, 2018

Regarding P1082R0: Could you double-check that you've applied the edit to meta.trans.ptr?

copied is operating system dependent. Creation failure because \tcode{p} resolves to an existing directory shall not be
treated as an error.
copied is operating system dependent.
Creation failure because \tcode{p} already exists is not treated as an error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"treated as" should be deleted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

\tcode{"\textmu{}s"} should be encoded as UTF-8. Otherwise UTF-16 or UTF-32 is encouraged.
The implementation may substitute other encodings, including \tcode{"us"}.
If \tcode{Period::type} is \tcode{micro},
but the character U+00B5 cannot be represented in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is the requested wording, but is U+00B5 really how we say things? Wouldn't it be more like "the character whose character short name is B5"? Or just "the character MICRO SIGN"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zygoloid, any guidance here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U+00B5 is really how the Unicode standard says things. See http://www.unicode.org/versions/Unicode11.0.0/appA.pdf

I see no reason to deviate from the relevant normative reference's notational convention here. Using U+00B5 MICRO SIGN (with MICRO SIGN in small-caps) seems OK too. I'm going to take this as-is for now.

Copy link
Contributor

@tkoeppe tkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual comments.

@jensmaurer
Copy link
Member Author

@tkoeppe: I did not update meta.trans.ptr, because common_type is in meta.trans.other. Furthermore, the underlying text has changed quite a bit here, the salient parts are now in "Note A" and "Note B", below the table. I think I did the best I could given the incoming text, but feel free to make specific improvement suggestions.

@zygoloid
Copy link
Member

I believe Thomas's comments have all been addressed, and I've done a review pass myself. LWG2139 is a bit of a merge conflict disaster, but I've convinced myself we've made all the requested changes.

@zygoloid zygoloid merged commit 8ca6219 into master Jun 21, 2018
@jensmaurer jensmaurer deleted the motions-2018-06-lwg-11 branch October 19, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants