Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re use of new type traits aliases #221

Closed
W-E-Brown opened this issue Oct 21, 2013 · 1 comment
Closed

Re use of new type traits aliases #221

W-E-Brown opened this issue Oct 21, 2013 · 1 comment

Comments

@W-E-Brown
Copy link
Contributor

  1. The recent edits using the _t transformation traits aliases seem slightly over-enthusiastic in one place: [pair.astuple] between p4 and p5: tuple_element_t is, as far as I know, not a valid alias. (I found no other occurrence.)

  2. On the other hand, the following shell script identifies, when run from the draft/source directory, some additional opportunities to apply the _t aliases. (The recent edits didn't find these because they're not prefaced by the typename keyword. In at least some cases the current code seems incorrect without that keyword.)

for F in        \
  add_const     \
  add_cv        \
  add_lvalue_reference  \
  add_pointer       \
  add_rvalue_reference  \
  add_volatile      \
  aligned_storage       \
  aligned_union     \
  common_type       \
  conditional       \
  decay         \
  enable_if     \
  make_signed       \
  make_unsigned     \
  remove_all_extents    \
  remove_const      \
  remove_cv     \
  remove_extent     \
  remove_pointer    \
  remove_reference  \
  remove_volatile   \
  result_of     \
  underlying_type       ;
do
  grep -n $F'<.*>::type' *.tex | grep -v 'using *'$F
done | sort -t : -k 1,1 -k 2,2n
@jwakely
Copy link
Member

jwakely commented Jan 21, 2014

  1. is issue std::tuple_element_t<> used without being defined #247 and fixed now

zygoloid pushed a commit to zygoloid/cplusplus that referenced this issue May 1, 2014
@W-E-Brown @zygoloid
Consistently employ _t suffixes when mentioning any type trait's
403d742 
resulting type.

Fixes cplusplus#221.
zygoloid pushed a commit to zygoloid/cplusplus that referenced this issue May 1, 2014
@W-E-Brown @zygoloid
Consistently employ _t suffixes when mentioning any type trait's
99fe1d0 
resulting type.

Fixes cplusplus#221.
burblebee pushed a commit that referenced this issue Apr 5, 2016
Consistently employ _t/_v suffixes when mentioning any type trait's r…
be071c8 
…esulting type/value.

Additional fixes for #221.
Patch from webrown.cpp@gmail.com.
FrankHB pushed a commit to FrankHB/draft that referenced this issue Jul 9, 2016
@FrankHB
Consistently employ _t/_v suffixes when mentioning any type trait's r…
9657575 
…esulting type/value.

Additional fixes for cplusplus#221.
Patch from webrown.cpp@gmail.com.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwakely @W-E-Brown