Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alg.shift], [fpos.operations] Annotate "old" requirements with \oldc… #2212

Merged

Conversation

CaseyCarter
Copy link
Contributor

…oncept

Fixes a few occurrences introduced by recently merged motions.

@@ -3603,10 +3603,10 @@
\pnum
\requires
The type of \tcode{*first} shall satisfy
the \tcode{MoveAssignable} requirements.
the \oldconcept{MoveAssignable} requirements.
\tcode{ForwardIterator} shall meet
the requirements of a bidirectional iterator\iref{bidirectional.iterators} or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\oldconcept{BidirectionalIterator}? (and next paragraph too)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't hurt to change this to shall meet the \oldconcept{BidirectionalIterator} requirements\iref{bidirectional.iterators}, but it's certainly not the only such occurrence. We need to audit the entire library for colloquialisms and replace them with proper requirement names to avoid confusion over whether e.g. "bidirectional iterator" means something that meets the old requirements, or the new requirements, or both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "colloquialism" was in fact the proper way to state such requirements. "bidirectional iterator" was not a CamelCasedRequirement before you made it one :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in [algorithms] =P

@zygoloid zygoloid merged commit 5133f19 into cplusplus:motions-2018-06-lwg-28 Jun 27, 2018
@CaseyCarter CaseyCarter deleted the motions-2018-06-lwg-28 branch June 27, 2018 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants