Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[algorithm.syn] Algorithm ordering inconsistency #2218

Closed
CaseyCarter opened this issue Jun 27, 2018 · 2 comments
Closed

[algorithm.syn] Algorithm ordering inconsistency #2218

CaseyCarter opened this issue Jun 27, 2018 · 2 comments

Comments

@CaseyCarter
Copy link
Contributor

In the algorithm synopsis, the declarations of the "partitions" (is_partitioned, partition, stable_partition, partition_copy, and partition_point) precede the declarations of the other "Sorting and related operations" (sort, nth_element, etc.) whereas the specifications of the "partitions" are located in [alg.partitions], smack in the middle of [alg.sorting], between [alg.binary.search] and [alg.merge].

I believe that:

  1. the ordering should be consistent, and
  2. the synopsis should be fixed to agree with the ordering of the detailed specifications.

If people agree with (1), I'll submit a PR. The exact form of that PR will depend on whether or not people agree with (2).
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Jun 27, 2018
@timsong-cpp
Copy link
Contributor

This was moved by #1245, which didn't reorder the synopsis to match.

@jensmaurer
Copy link
Member

@timsong-cpp, thanks for the archeology. So, the synopsis should be fixed. @CaseyCarter, go ahead.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Jun 27, 2018
CaseyCarter added a commit to CaseyCarter/draft that referenced this issue Jun 27, 2018
@CaseyCarter
[algorithm.syn] Relocate the "partitions" algorithms
af98771 
between the "binary_search" family and the "merge" family, to agree with
the order of the detailed specifiations as reordered by cplusplus#1245.

Fixes cplusplus#2218.
@CaseyCarter CaseyCarter mentioned this issue Jun 27, 2018
Merged
@jensmaurer jensmaurer changed the title Algorithm ordering inconsistency [algorithm.syn] Algorithm ordering inconsistency Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CaseyCarter @timsong-cpp @jensmaurer