Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class.mem] Define complete-class context #2231

Merged
merged 1 commit into from Jul 2, 2018
Merged

Conversation

jensmaurer
Copy link
Member

and use it, instead of having separate redundant lists
in [basic.scope.class] and [basic.lookup.unqual].

Fixes #2107.

contract condition\iref{dcl.attr.contract},
or nested class definition\footnote{This refers to unqualified names
following the class name; such a name may be used in the
\grammarterm{base-clause} or may be used in the class definition.}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of this footnote intentional? Clarifying that this covers the base-specifiers seems at least moderately useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed so... obvious to me, but we seem to have several similar footnotes in the vicinity. Restored.

@@ -1404,11 +1395,7 @@

\pnum
For the members of a class \tcode{X}, a name used
in a member function body,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, we meant "function body" here, not "member function body". This is technically a normative change, but it's obvious that the new wording is correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we're good here, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

and use it, instead of having separate redundant lists
in [basic.scope.class] and [basic.lookup.unqual].
complete-class context\iref{class.mem} of \tcode{X}\footnote{This
refers to unqualified names following the class name;
such a name may be used in the \grammarterm{base-clause} or
may be used in the class definition.}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (pre-existing) footnote text is appalling :(

"A name used in the definition of a class [...] refers to [...] a name used in the base-clause or [...] in the class definition".

What? So "in the definition of a class" is a broader syntactic category than "in the class definition"? I'll fix that after merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zygoloid zygoloid merged commit 4d757ab into cplusplus:master Jul 2, 2018
@jensmaurer jensmaurer deleted the b11 branch July 12, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants