Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concept.swappable] remove wrongly included text #2237

Merged
merged 1 commit into from Jul 2, 2018

Conversation

timsong-cpp
Copy link
Contributor

@timsong-cpp timsong-cpp commented Jul 2, 2018

These paragraphs are in magenta in P0898R3 and are not meant to be included into the IS working draft.

@CaseyCarter
Copy link
Contributor

@timsong-cpp is right: this is my mistake.

These paragraphs are in magenta in P0898R3 and are not meant to be included into the IS working draft.
@timsong-cpp timsong-cpp force-pushed the patch-3 branch 2 times, most recently from 889f46d to 0956468 Compare July 2, 2018 04:24
@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 2, 2018

Ah, that's because plain "magenta" isn't a thing: P0893R3 only defines "mangeta with strikethrough". So I suppose that's an error in the original paper already that translated into erroneous application?

@tkoeppe tkoeppe merged commit 7231f47 into cplusplus:master Jul 2, 2018
@timsong-cpp timsong-cpp deleted the patch-3 branch July 2, 2018 08:57
@CaseyCarter
Copy link
Contributor

Ah, that's because plain "magenta" isn't a thing: P0893R3 only defines "mangeta with strikethrough".

The magenta comes from the \oldtxt macro, which is basically \removed with a different color. It can't be applied to markup, and large blocks of strikethrough do nothing for clarity, so I usually just {\color{oldclr} ...} large blocks. The error in the paper is not describing the usage of "red/magenta without strikethrough" and "cyan/gold without underline" correctly.

Also, "Mangeta" sounds like one of Godzilla's opponents - or a Super Sayan.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 2, 2018

"Mangeta" is clearly the spin-off following the adventures of Magneta's manservant.

Attractive. — Critics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants