Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1076R1: Editorial clause reorganization #2243

Merged
merged 12 commits into from Jul 6, 2018
Merged

P1076R1: Editorial clause reorganization #2243

merged 12 commits into from Jul 6, 2018

Conversation

jensmaurer
Copy link
Member

Fixes #1919 and #1511.

@zygoloid
Copy link
Member

zygoloid commented Jul 3, 2018

[class.copy] seems a bit lost and lonely. (Also, the final cross-reference in p1 seems like it should point to [class.copy.assign], not to [over.ass].) Does [class.copy] serve any purpose? Is there any normative weight in either of its paragraphs? (Can we just strike it?)

I think the resulting structure of [algorithms] could do with some more attention. Listing the synopsis at the top level but putting the synopsis under "Generalized numeric operations" creates an asymmetry between them. Perhaps the synopsis could be promoted to 23.8 or to 23.3, to match the synopsis in 23.2?

[numeric.ops.overview]p1 appears to be redundant now.

Otherwise, this looks great.

@jensmaurer
Copy link
Member Author

[class.copy] has been removed. Throughout the standard, there were 44 cross-reference to be adjusted.

@jensmaurer
Copy link
Member Author

[numeric.ops] as been integrated better into [algorithms]: Synopsis is a separate subclause, [numeric.ops.overview]p1 is gone, [numeric.ops.overview]p2 has been moved to [algorithms.requirements] (because the existing [alg.transform] also uses template parameters named UnaryOperation and BinaryOperation). This way, it's also very obvious that these template parameters are underspecified.

@jensmaurer jensmaurer requested a review from zygoloid July 4, 2018 06:42
@jensmaurer jensmaurer added this to the post-2018-06 milestone Jul 4, 2018
@zygoloid
Copy link
Member

zygoloid commented Jul 6, 2018

I've reordered the synopsis a bit later. We now have:

  • General
  • Algorithm requirements
  • Parallel algorithms
  • synopsis
  • ( content subclauses)
  • ( content subclauses)
  • synopsis
  • content subclause
  • algorithms

jensmaurer and others added 12 commits July 5, 2018 20:28
…h.conv]

P1076R1: Editorial clause reorganization
P1076R1: Editorial clause reorganization
P1076R1: Editorial clause reorganization
P1076R1: Editorial clause reorganization
P1076R1: Editorial clause reorganization
P1076R1: Editorial clause reorganization
The normative statements that used to be contained in
[class.copy] were redundant with [dcl.init] and [over.ass].
[algorithms.parallel], which apply to both <algorithm> and <numeric>.
@zygoloid zygoloid merged commit 0e3c91b into master Jul 6, 2018
@jensmaurer jensmaurer deleted the 2018-06-p1076r1 branch October 19, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants