Use the Oxford comma in [class.copy.assign]. #2257
Conversation
source/classes.tex
Outdated
| \tcode{M} | ||
| (or array thereof), | ||
| for all the non-static data members of \tcode{X} that are of a class type | ||
| \tcode{M} (or array thereof), |
There was a problem hiding this comment.
Since you're re-flowing the source here: We want semantic linebreaks, but the best position to break seems to be before the "that" (which starts a relative clause).
Quuxplusone
force-pushed
the
oxford-comma
branch
from
98b44e0
to
0dd6b27
Compare
|
Addressed! |
|
Looks good, but could you kindly make and attach diffpdf screenshot (in "appearance" comparison mode)? |
Not I; I haven't got diffpdf. Maybe someone not-me could. |
zygoloid
added
the
decision-required
|
We currently have a mixture of spaces-in- With
With spaces inside
Clearly our full code examples are going to use the spaces-inside- |
jensmaurer
added
the
needs rebase
|
I agree it's more beautiful to split the |
|
FWIW, I *don't* agree that splitting tcodes is more beautiful; I think the
different width spaces are noticeable and technically distracting (is a
`const` `int&` different from a `const int&`?). So I'd prefer not to split,
for that technical reason. But I don't care very much.
…On Tue, Oct 9, 2018, 12:15 PM Jens Maurer ***@***.***> wrote:
I agree it's more beautiful to split the \tcodes, but it's also less
grep-able and less readable in the text editor for the LaTeX source. Let's
not split \tcode.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2257 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAq2Rb_xctGHv1Hwe7femSHDJSH98-c4ks5ujPXAgaJpZM4VL7I7>
.
|
|
@Quuxplusone, could you please rebase, thereby resolving the conflicts? |
Quuxplusone
force-pushed
the
oxford-comma
branch
from
0dd6b27
to
e6fb0c5
Compare
jensmaurer
removed
the
needs rebase
|
Editorial meeting: If the space is part of the technical content (such as the "const volatile X&" example above), the space is part of the \tcode. With that decision made, we merge this change. |
jensmaurer
removed
the
decision-required
And turn a bunch of
\tcode{const} \tcode{X}into\tcode{const X}on the assumption that this is better. (I see the latter style being used elsewhere, and it's certainly more readable in the TeX source.)