Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dcl.array] Rework description. #2274

Merged
merged 1 commit into from Jun 14, 2019
Merged

[dcl.array] Rework description. #2274

merged 1 commit into from Jun 14, 2019

Conversation

jensmaurer
Copy link
Member

Group examples with the corresponding normative statements.
Clarify the meaning of 'array type'.
Use 'declarator-id' instead of 'identifier'.

Fixes #2175.

@jensmaurer jensmaurer requested a review from zygoloid July 21, 2018 14:29
zygoloid
zygoloid reviewed Oct 9, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Oct 9, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Oct 9, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
@zygoloid zygoloid added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 9, 2018
@zygoloid zygoloid mentioned this pull request Oct 9, 2018
Merged
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 9, 2018
@zygoloid zygoloid added the after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. label Oct 9, 2018
zygoloid
zygoloid reviewed Nov 26, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Nov 26, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Nov 26, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Nov 26, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
zygoloid
zygoloid reviewed Nov 26, 2018
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
zygoloid
zygoloid requested changes Nov 26, 2018
View reviewed changes
Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd like the definition of "array type" and "element type" fixed before we merge this.

@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. and removed after-motions Pull request is to be applied after the pending edits from WG21 straw polls have been applied. labels Nov 27, 2018
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Apr 18, 2019
zygoloid
zygoloid requested changes Jun 12, 2019
View reviewed changes
source/declarations.tex Outdated Show resolved Hide resolved
source/declarations.tex Outdated Show resolved Hide resolved
source/declarations.tex Outdated Show resolved Hide resolved
@zygoloid zygoloid added the changes requested Changes to the wording or approach have been requested and not yet applied. label Jun 12, 2019
@jensmaurer
[dcl.array] Rework description.
d2f27fc 
Group examples with the corresponding normative statements.
Clarify the meaning of 'array type'.
Use 'declarator-id' instead of 'identifier'.
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Jun 13, 2019
@k-satoda
Copy link
Contributor

@jensmaurer Could you please take another look on PR #2327?

#2327 was closed as its change was subsumed by this PR. But I can't see
the change in #2327 (for [expr.new]) in this PR (for [dcl.array] only).

@jensmaurer
Copy link
Member Author

@k-satoda, I've reopened #2327. It needs a rebase, though.

@zygoloid zygoloid merged commit 6f99598 into cplusplus:master Jun 14, 2019
@jensmaurer jensmaurer deleted the b16 branch June 14, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpplearner cpplearner cpplearner left review comments

@zygoloid zygoloid zygoloid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dcl.array]/1 This grammar does not always declare an array.
4 participants
@jensmaurer @k-satoda @zygoloid @cpplearner