Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class.virtual] missing a definition of "virtual function" #2290

Closed
zygoloid opened this issue Aug 7, 2018 · 0 comments
Closed

[class.virtual] missing a definition of "virtual function" #2290

zygoloid opened this issue Aug 7, 2018 · 0 comments
Assignees

Comments

@zygoloid
Copy link
Member

zygoloid commented Aug 7, 2018

We never define what a "virtual function" is.

Starting point for wording (as discussed on core reflector): prepend to [class.virtual]p1:

"A non-static member function is a virtual function if it is first declared with the keyword virtual or if it overrides a virtual member function declared in a base class (see below)."

Additional cleanups:

In [class.virtual]p2, strike the "is also virtual (whether or not it is so declared) and it", since that follows from the definition of "virtual function".

Move the second sentence of footnote 115 to a new footnote 115a attached to the newly added sentence in [class.virtual]p1, and replace the word "legal" with "well-formed" or "valid". Replace "has empty semantics" with "has no semantic effect".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants