Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-type paramaters can have class type #2329

Merged
merged 1 commit into from Sep 21, 2018
Merged

Non-type paramaters can have class type #2329

merged 1 commit into from Sep 21, 2018

Conversation

Kannen
Copy link
Contributor

@Kannen Kannen commented Sep 10, 2018

No description provided.

jensmaurer
jensmaurer requested changes Sep 15, 2018
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to start with the label of the section you're modifying, e.g. "[basic.def.odr] Fix smell of ODR".

Please name in the commit description the PxxxxRy document that allowed non-type template parameters of class type.

Please fix the typo in the heading.

@zygoloid zygoloid merged commit e160ea1 into cplusplus:master Sep 21, 2018
@zygoloid
Copy link
Member

@jensmaurer I addressed your comments when merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kannen @zygoloid @jensmaurer