Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shuffle() in [algorithms.general] and [alg.random.shuffle] is poorly indented #233

Closed
StephanTLavavej opened this issue Nov 19, 2013 · 0 comments
Closed

shuffle() in [algorithms.general] and [alg.random.shuffle] is poorly indented #233

StephanTLavavej opened this issue Nov 19, 2013 · 0 comments

Comments

@StephanTLavavej
Copy link
Contributor

N3797 25.1 [algorithms.general]:

template<class RandomAccessIterator, class UniformRandomNumberGenerator>
  void shuffle(RandomAccessIterator first,
                      RandomAccessIterator last,
                      UniformRandomNumberGenerator&& rand);

25.3.12 [alg.random.shuffle]:

template<class RandomAccessIterator, class UniformRandomNumberGenerator>
  void shuffle(RandomAccessIterator first,
                      RandomAccessIterator last,
                      UniformRandomNumberGenerator&& g);

The third and fourth lines aren't aligned with the second (these signatures appear to have been copy-paste-edited from random_shuffle() which is properly aligned).

Additionally, the [algorithms.general] synopsis should name the URNG "g", for consistency with its definition.
FrankHB pushed a commit to FrankHB/draft that referenced this issue Jul 9, 2016
@FrankHB
[algorithms.general] Fix indenting of shuffle (cplusplus#233)
601421d 
Fixes cplusplus#233.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StephanTLavavej