Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alg.shift] Slight mismatch with accepted proposal wording #2337

Closed
danra opened this issue Sep 19, 2018 · 2 comments
Closed

[alg.shift] Slight mismatch with accepted proposal wording #2337

danra opened this issue Sep 19, 2018 · 2 comments

Comments

@danra
Copy link
Collaborator

danra commented Sep 19, 2018

The Returns clause 3 under [alg.shift] in P0769R2 says
Returns: first + (last – first) – n if n is positive...

The matching clause in the latest published Standard draft (n4762) is slightly different:
Returns: first + (last – first – n) if n is positive...

Was this change done intentionally? If not, can we keep the original ones?

Thanks,
Dan
@danra danra changed the title [alg.shift] Slight mismatch with the accepted proposal in text in Returns clause [alg.shift] Slight mismatch with accepted proposal wording Sep 19, 2018
@cpplearner
Copy link
Contributor

cpplearner commented Sep 19, 2018 •
edited

I guess the standard wants to avoid subtraction between ForwardIterator and number.

@danra
Copy link
Collaborator Author

danra commented Sep 20, 2018 •
edited

@cpplearner Ah, that makes sense. Thanks!

@danra danra closed this as completed Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danra @cpplearner