Remove "shall equal"s naming from conditional/decay/enable_if #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of saying "shall equal", which implies a condition on the user, we should say "names" or "is". This change uses 'names', since that's what `identity` uses: The member typedef `type` names the type `T`. Suggestion from Alisdair.
CaseyCarter
reviewed
Oct 12, 2018
source/utilities.tex
Outdated
| @@ -16940,15 +16940,15 @@ | |||
| \tcode{template<bool B, class T = void>} \tcode{struct enable_if;} | |||
| & | |||
| If \tcode{B} is \tcode{true}, the member typedef \tcode{type} | |||
| shall equal \tcode{T}; otherwise, there shall be no member | |||
| names \tcode{T}; otherwise, there shall be no member | |||
There was a problem hiding this comment.
s/shall be/is/ since you're touching this line anyway?
There was a problem hiding this comment.
Makes sense to me. But then, should we fix common_type (probably not, since users can specialize it), basic_common_reference (ditto), invoke_result (probably should).
There was a problem hiding this comment.
Yes, we should fix those, but notably none of them are on this line. ;)
CaseyCarter
approved these changes
Oct 12, 2018
|
I agree with the desire to remove "shall equal", but I'm wondering whether "names the type..." would be better. Otherwise, we have a type-id without any introducer at all. |
|
On Oct 13, 2018, at 1:13 PM, Jens Maurer ***@***.***> wrote:
I agree with the desire to remove "shall equal", but I'm wondering whether "names the type..." would be better. Otherwise, we have a type-id without any introducer at all.
Alternatively, we could rephrase as "denotes" or "denotes the type", as we say in a number of places.
There's also "alias" (as in "is an alias for" or, as a verb, "aliases"). We do already use similar phrasing, e.g., "provides an alias" and "be an alias for".
|
|
Oh, the issue I wanted to open is already here. |
zygoloid
changed the title
zygoloid
added
the
decision-required
|
Editorial meeting consensus:
|
jensmaurer
added
changes requested
|
#2678 supersedes this PR, so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saying "shall equal", which implies a condition on the user, we should say "names" or "is".
This change uses 'names', since that's what
identityuses: The member typedeftypenames the typeT.Suggestion from Alisdair.