Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iterator.operations] Harmonize bad wording with shiny new Ranges wording #2361

Merged
merged 3 commits into from Nov 26, 2018
Merged

[iterator.operations] Harmonize bad wording with shiny new Ranges wording #2361

merged 3 commits into from Nov 26, 2018

Conversation

CaseyCarter
Copy link
Contributor

No description provided.

tkoeppe
tkoeppe reviewed Oct 17, 2018
View reviewed changes
source/iterators.tex Outdated Show resolved Hide resolved
@CaseyCarter
Copy link
Contributor Author

CaseyCarter commented Oct 17, 2018 •
edited

This changes the precondition wording for advance and distance to agree with the wording for ranges::advance and ranges::distance which LWG was happy with in Batavia. The absolute-value change for the effects of advance is novel, but certain to be non-controversial (and I am changing P0896 to agree).

@CaseyCarter CaseyCarter changed the title [iterator.operations] advance does not decrement by a negative count [iterator.operations] Harmonize bad wording with shiny new Ranges wording Oct 18, 2018
@jensmaurer
Copy link
Member

jensmaurer commented Oct 18, 2018 •
edited

Strictly speaking, the Ranges proposal has not been approved by WG21 for inclusion into the IS, yet.
But I just noticed that the commit comments don't mention Ranges, just the title of this pull request does. So, we're fine.

zygoloid
zygoloid requested changes Nov 26, 2018
View reviewed changes
source/iterators.tex Outdated Show resolved Hide resolved
source/iterators.tex Outdated Show resolved Hide resolved
@zygoloid zygoloid merged commit 05f51e0 into cplusplus:master Nov 26, 2018
@CaseyCarter CaseyCarter deleted the advance_abs branch November 27, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@zygoloid zygoloid zygoloid requested changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CaseyCarter @jensmaurer @zygoloid @tkoeppe