Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different vertical positioning of items in top-level clause summary tables #2392

Closed
JohelEGP opened this issue Nov 9, 2018 · 5 comments · Fixed by #2869
Closed

Different vertical positioning of items in top-level clause summary tables #2392

JohelEGP opened this issue Nov 9, 2018 · 5 comments · Fixed by #2869
Assignees

Comments

@JohelEGP
Copy link
Contributor

JohelEGP commented Nov 9, 2018

1541797347
One subclase, various headers, first row positioning.


1541797422
Various subclauses, one header, first row positioning.


1541797453
One subclase, various headers, centralized positioning.


1541797587
Various subclauses, one header, centralized positioning.


I thought it might be desirable to decide on a style. I personally prefer the centralized positionings.

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 27, 2018
@JohelEGP
Copy link
Contributor Author

JohelEGP commented Dec 6, 2018

1541797422

Should the (s) in Header(s) be dropped, or added to Subclause too?

@zygoloid
Copy link
Member

zygoloid commented Dec 7, 2018

  • Yes, we should consistently apply one style.
  • If we use a vertically-centered style, we should do that properly (eg, \multirow rather than the current "put the text in the right cell, maybe off by half a row" approach)
  • Yes, we should consistently either pluralize or not pluralize the column headings
  • Also fix the summary table in [atomics.general] to remove the line separators between <atomic> entries

@jensmaurer
Copy link
Member

jensmaurer commented Dec 7, 2018

@zygoloid, thanks for your input. However, there are a lot of "if"s here. Here are my preferences:

  • use first row positioning
  • do not pluralize the column headings (we also say "Subclause", not "Subclauses")

@tkoeppe, any opinion here?

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 7, 2018

I agree with first-row positioning. Centering of any kind is "cute" but ultimately distracting. I also prefer staying on the baseline; on introspection I am finding this to be a rather strong preference.

I have no strong opinion on the plural issue, but I agree that the "header" and "subclause" columns deserve the same treatment, whatever that is. Plural may be a bit more accurate to how we end up using this column, but since many instances don't have more than one entry, a flat-out plural ("headers") might be confusing. But the parenthesized style ("header(s)") looks clunky, so I'm inclined to agree with Jens's suggestion to not pluralize.

Tangential: The overall visual style of the summary tables is abhorrent. I have a local patch to make my PDFs look less repelling; I'd welcome encouragement to propose changes.

@jensmaurer
Copy link
Member

Editorial meeting:

  • Vertically aligned at the top (first-row positioning).
  • Singularize the headings; just say "Header" always.
  • Fix "atomic" table.
  • Left-align "Subclause" heading with the title.
  • Linearize the headers (make it a list, comma-separated). Sort the header list lexicographically.
  • Remove horizontal lines between sections having the same set of headers.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Feb 22, 2019
@jensmaurer jensmaurer self-assigned this May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants