Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the contexts where void expressions appear #2393

Merged
merged 2 commits into from Jan 18, 2019

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Nov 10, 2018

This pull request will:

  • remove void expressions from temporary object materialization;
  • add void expressions to the definition of prvalues and precise that they have no results nor result objects.

@zygoloid zygoloid added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Nov 26, 2018
@jwakely
Copy link
Member

jwakely commented Nov 26, 2018

FWIW I find the title of this pull request extremely confusing every time I see it. The use of "precisions" makes me think of the number of significant digits printed out for a floating point number.

These changes are not "precisions", they're clarifications, or "more precise descriptions".

@geryogam geryogam changed the title Add precisions for void expressions Clarify the contexts where void expressions appear Nov 26, 2018
@geryogam
Copy link
Contributor Author

geryogam commented Nov 26, 2018

@zygoloid Pull request rebased.
@jwakely Thank you for the suggestion, title changed.

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 1, 2018
@zygoloid zygoloid merged commit 27d1966 into cplusplus:master Jan 18, 2019
@geryogam geryogam deleted the patch-2 branch January 19, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants