Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2018-11 LWG Motion 11] P1032R1 Misc constexpr bits #2417

Closed
jensmaurer opened this issue Nov 10, 2018 · 3 comments · Fixed by #2495
Closed

[2018-11 LWG Motion 11] P1032R1 Misc constexpr bits #2417

jensmaurer opened this issue Nov 10, 2018 · 3 comments · Fixed by #2495
Assignees
@zygoloid
Milestone
post-2018-11

Comments

@jensmaurer
Copy link
Member

jensmaurer commented Nov 10, 2018 •
edited

P1032R1
@jensmaurer jensmaurer added this to the post-2018-11 milestone Nov 10, 2018
@zygoloid zygoloid self-assigned this Nov 14, 2018
zygoloid added a commit to zygoloid/cplusplus that referenced this issue Nov 14, 2018
@zygoloid
P1032R1 Misc constexpr bits
fda3148 
[tuple], [pairs.pair] Fixed relative order of 'explicit' and 'constexpr'

Change 9: formatting and grammar fixes, replaced meaningless phrase
"operations are constexpr" with intended "operations are implemented
with constexpr functions" after consultation with LWG.

Change 10: green line editing instruction ignored, there do not appear
to be any other places that need changes.

Fixes cplusplus#2417
@burblebee
Copy link
Contributor

@zygoloid I figured we'd use the "Assignees" in the associated PRs to designate the reviewer(s), but since this commit wasn't done thru a PR, how do we know who the official reviewer is?

FWIW, I'll take this one on as the "official" reviewer...

@burblebee
Copy link
Contributor

In order to review the changes I want to build the paper from the sources, but commit fda3148 isn't known to my git. How to build the std from these sources???

@zygoloid
Copy link
Member

zygoloid commented Nov 20, 2018 •
edited

@burblebee Oops, sorry, it was pushed to my personal fork of the repository rather than this one. I've pushed it to the right place now.

@zygoloid zygoloid mentioned this issue Nov 20, 2018
Merged
zygoloid added a commit that referenced this issue Nov 26, 2018
@zygoloid
P1032R1 Misc constexpr bits
ae57182 
[tuple], [pairs.pair] Fixed relative order of 'explicit' and 'constexpr'

Change 9: formatting and grammar fixes, replaced meaningless phrase
"operations are constexpr" with intended "operations are implemented
with constexpr functions" after consultation with LWG.

Change 10: green line editing instruction ignored, there do not appear
to be any other places that need changes.

Fixes #2417
zygoloid added a commit that referenced this issue Nov 26, 2018
@zygoloid
Merge 2018-11 LWG Motion 11
e36cd33 
P1032R1 Misc constexpr bits

Fixes #2417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zygoloid zygoloid

Labels
None yet
Projects
None yet
Milestone
post-2018-11
Development

Successfully merging a pull request may close this issue.

P1032R1 Misc constexpr bits cplusplus/draft
3 participants
@zygoloid @burblebee @jensmaurer