New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2018-11 LWG Motion 12] P1148R0 Cleaning up Clause 20 #2418
Comments
Sources for paper: https://github.com/timsong-cpp/string-cleanup |
@zygoloid I assume you'll be the official reviewer for this paper? As with lwg-11, there's no PR so can't use that to assign the reviewer. Also, the sources just list the files - how do we see the changes in diff form from that (so we can review, comment, etc.)? It seems there must be a way to do this in github (short of creating a PR from them). |
@burblebee: We can only directly use the sources if we have a common ancestor in the git version tree. Even then, we need to rebase to a reasonably recent commit and resolve the conflicts. Otherwise, the sources are just helpful input to create our own commit (because we don't have to redo all the formatting). Since @zygoloid is working on this, I suspect he'll do exactly this. |
As implied by the intro to the paper, the base LaTeX for |
I don't think that's true. I believe all you need is the same directory structure. Then you can add that other repository as a remote and apply its commits to yours. I have done this with two repositories of mine to easily adopt improvement to files somewhat generic to my projects, like |
@JohelEGP That doesn't really work very well here. The paper sources have taken our sources and added |
P1148R0 Cleaning up Clause 20 Fixes #2418
Ignoring the apparent markup changes that @zygoloid spoke of in his comment above, I'd still like to know how to create a branch from a list of referenced source files, such as was supplied here. Is it really as tedious as downloading all the files, creating a reverse diff from them back to the original paper they were based on, and applying those diffs to the master sources? There's got to be a way to use github to do this, no? |
@burblebee Given a Git repo, just set it as a remote and pull from it into a new branch. Given a bunch of source files (not in a Git repo), create a new local branch, replace the files in your branch with the ones from the "list of referenced source files", commit. Now you have a branch containing those sources. |
P1148R0
The text was updated successfully, but these errors were encountered: